[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Chicken-hackers] [PATCH] Detect and signal error on stack overflow
From: |
Peter Bex |
Subject: |
Re: [Chicken-hackers] [PATCH] Detect and signal error on stack overflow in `apply` |
Date: |
Sat, 10 Sep 2016 13:03:27 +0200 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Sat, Sep 10, 2016 at 10:58:28PM +1200, Evan Hanson wrote:
> On 2016-09-10 12:41, Peter Bex wrote:
> > Looks good to me, except for one thing: changing the signature of
> > C_stack_overflow(). This should be avoided in master, because who
> > knows what eggs rely on this function's signature.
>
> Good point -- here's an updated version for master that adds a
> "_with_loc" variant instead, like you suggest.
Looks good to me, feel free to apply it.
Cheers,
Peter
signature.asc
Description: Digital signature