chicken-hackers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Chicken-hackers] [PATCH][5] Add `include-relative` form to "chicken" mo


From: Evan Hanson
Subject: [Chicken-hackers] [PATCH][5] Add `include-relative` form to "chicken" module
Date: Tue, 9 Aug 2016 23:55:38 +1200

Hi Peter,

On 2016-07-16 20:11, Peter Bex wrote:
> An include-relative is defined by the s48-modules egg.  I think it
> makes more sense to have that, especially considering we also have
> load-relative.

Fair enough, here's a version that does that instead. For consistency
I've tried to make `include-relative` behave as much like
`load-relative` as possible. For example, when used from within a file
it will include, erm, relatively, and when used from a non-file context
(e.g. from a csi session) it will behave as though the "current file" is
in the working directory.

It also inherits a small problem with `load-relative` that I noticed
while working on the patch, which is that only paths beginning with
slashes are considered absolute, not paths beginning with drive letters
when on Windows. It might be worth fixing this in a later changeset.

> I'm not sure whether it would make more sense to have include-relative
> also honor the include path or not.

I don't know either. I've done so, but I'm open to changing it if any
hackers have a strong opinion in the other direction.

Cheers,

Evan



reply via email to

[Prev in Thread] Current Thread [Next in Thread]