chicken-hackers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Chicken-hackers] [PATCH 0/3][5] More chicken-5 module work


From: Peter Bex
Subject: Re: [Chicken-hackers] [PATCH 0/3][5] More chicken-5 module work
Date: Thu, 16 Jun 2016 13:58:29 +0200
User-agent: Mutt/1.5.23 (2014-03-12)

On Sat, Jun 04, 2016 at 12:03:22AM +1200, Evan Hanson wrote:
> Hi folks,
> 
> Here are some library reorganization patches for chicken-5.

Great stuff, as usual!  I've pushed this.

> The first creates a "chicken.memory" module per the "ICC minutes" on the
> reorg page[1]. I only moved the procedures that were "Decided", so there
> are still a bunch left in lolevel that need a home. Those are:
> 
>    block-ref block-set! extend-procedure extended-procedure?
>    make-record-instance mutate-procedure! number-of-bytes
>    number-of-slots object-become! object-copy procedure-data
>    record->vector record-instance-length record-instance-slot
>    record-instance-slot-set! record-instance-type record-instance?
>    set-procedure-data! vector-like?
> 
> As you can see, it's bit of a grab bag. I welcome any and all
> taxonomical suggestions.

How about (chicken memory object)?  This is after all direct access to
the internal representation of objects.  This should also house the
renamed versions of ##sys#slot and ##sys#set[i]slot.

> The second patch creates "chicken.errno". Pretty simple, that one.

I do think the way errno is defined in library.scm but exported by
(chicken memory) is a bit weird.  Also, note that currently errno is
still *also* exported by the "chicken" module.  Eventually I guess this
module will disappear anyway.  But it would make more sense if the errno
definition would be elsewhere.

Perhaps we could move the errno module into library.  Unfortunately, that
would mess with the Windows/UNIX distinction we have now.

> The last patch removes `group-information` from the posix unit, as well
> as the procedures that deal with supplementary process groups, all of
> which I've moved to an egg that's ready to be tagged. I've tentatively
> called the egg "posix-groups", but I'd love it if someone thought of a
> better name; it contains, rougly, getgrnam(3), getgroups(3),
> setgroups(3) and initgroups(3). A nice side effect of this removal is
> that we can drop quite a few ifdefs that check for <grp.h> availabily,
> since nothing else needs it.

Ah, that's very cool.  Less ifdefs make me happy :)

Thanks again for putting in the effort!

Cheers,
Peter

Attachment: signature.asc
Description: Digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]