[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Chicken-hackers] [PATCH] [PRERELEASE] Fix #1285
From: |
Peter Bex |
Subject: |
Re: [Chicken-hackers] [PATCH] [PRERELEASE] Fix #1285 |
Date: |
Sun, 22 May 2016 13:40:50 +0200 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Sun, May 22, 2016 at 09:28:34AM +1200, Evan Hanson wrote:
> Hi Peter,
>
> Thanks for looking into this. Your patch looks good as a fix for the
> parameter restoration problem, but we also need to return the new value
> from these fake parameters when they're called with arguments, even when
> `set?` is false. Otherwise, the conversion step in the before thunk will
> receive the original value to use as the new one, making the
> parameterize a noop.
D'oh! Sorry about that.
> Attached is a supplemental patch (0002) that does this. I also went
> through the project looking for other procedures that are documented as
> parameters but aren't really, and the only one I could find was
> `repository-path` so I've also included a patch (0003) that makes this a
> true parameter object.
>
> The final patch (0001) is just a signoff for yours, which I'm happy to
> be applied with the others.
All pushed. If the prerelease Salmonella runs are okay, I will tag a
release for 4.11.0 later this week.
Cheers,
Peter
signature.asc
Description: Digital signature