|
From: | Peter Bex |
Subject: | Re: [Chicken-hackers] [PATCH] A few fixes and improvements for -deploy mode and csc.scm |
Date: | Thu, 21 Jan 2016 21:35:18 +0100 |
User-agent: | Mutt/1.5.21 (2010-09-15) |
On Mon, Jan 18, 2016 at 09:22:25AM +0100, Peter Bex wrote: > On Sun, Jan 17, 2016 at 03:58:07PM +0000, Mario Domenech Goulart wrote: > > Attached you can find the quoting-related patches for chicken-5. I've applied and pushed those. > > With regard to > > 0003-Add-prefix-support-to-chicken-uninstall-status.master.patch , it > > seems that the argument to -prefix is a bit inconsistent for > > chicken-{status,uninstall} compared to chicken-install. For example, > > I've set ~/.eggs as the alternative location for eggs: > > > > $ chicken-install -prefix ~/.eggs salmonella > > ... > > > > $ chicken-status -prefix ~/.eggs salmonella > > (none) > > > > $ chicken-status -prefix ~/.eggs/lib/chicken/8/ salmonella > > salmonella .............................................. version: 2.7 > > salmonella-cmd .......................................... version: 2.7 > > salmonella-epidemy ...................................... version: 2.7 > > salmonella-log-merger ................................... version: 2.7 > > salmonella-log-parser ................................... version: 2.7 > > salmonella-log-viewer ................................... version: 2.7 > > > > Am I missing something? > > No, this is supposed to work, and I think I tested it. But maybe I > broke something later on. I'd have to take another look. I took another look, and it turns out I've only tested with -deploy. Attached are new versions of the 0003 and 0004 patches of my original mail, which take a different approach: instead of parameterizing the repository-path, which is not very controlled, I copied some housekeeping code from chicken-install as well as setup-api.scm's "repo-path". It's a tangled mess, but I *think* this works as intended, now. At least, chicken-status and chicken-uninstall now behave consistently with chicken-install when passed -prefix, with and without -deploy. This setup stuff is quite in need of a rewrite, or at least the code really needs to be cleaned up. And it doesn't help that eval.scm has some of the extension-information stuff as well! Anyway, even though it's messy, I think this patch is useful as is, and it fixes an annoying bug. Cheers, Peter
0001-Add-prefix-and-deploy-support-to-chicken-uninstall-s.chicken-5.patch
Description: Text Data
0002-Do-not-reinstall-satisfied-deps-in-deploy-mode.chicken-5.patch
Description: Text Data
0001-Add-prefix-and-deploy-support-to-chicken-uninstall-s.master.patch
Description: Text Data
0002-Do-not-reinstall-satisfied-deps-in-deploy-mode.master.patch
Description: Text Data
signature.asc
Description: Digital signature
[Prev in Thread] | Current Thread | [Next in Thread] |