chicken-hackers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Chicken-hackers] [PATCH] Error when emitting import libraries for m


From: Evan Hanson
Subject: Re: [Chicken-hackers] [PATCH] Error when emitting import libraries for modules that don't exist
Date: Fri, 1 Jan 2016 19:23:01 +1300

Hi Peter,

Pushed, with some subsequent commits to address a few corner cases
involving "-emit-all-import-libraries" and the like. A particularly fun
one was that mini-srfi-1's `delete` only removed the first `equal?`
element, so something like "-j foo -j foo" would cause an error on
chicken-5.

Bootstrapping that branch also uncovered the fact that we were trying to
emit an import library for chicken.scm when it wasn't a module, so I've
taken the opportunity to make it one.

On 2015-11-19 16:05, Peter Bex wrote:
> I'm not 100% happy with the way this patch mutates the import libraries
> list, but it's the simplest way I could think of.  Another approach
> could be to maintain a second list with the libraries that were emitted
> and check the original list against that, but that's a bit more
> complicated and adds yet another global variable.

Oh well. If we ever need the initial list intact in the future, we'll
change it then.

Cheers,

Evan

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]