[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Chicken-hackers] [PATCH] Improve irregex matching performance a lot
From: |
felix . winkelmann |
Subject: |
Re: [Chicken-hackers] [PATCH] Improve irregex matching performance a lot by adding two type declarations |
Date: |
Tue, 08 Dec 2015 22:35:35 +0100 |
> Now, if you look at the patch you'll see that it changes irregex-core.scm,
> which means it creates a "fork" against that part of the code in upstream.
> I don't see a way to declare the type from the "outside", in irregex.scm,
> unless we also copy that code body as a macro, but that feels really ugly
> and will cause some code duplication in the resulting C code.
I suggest creating a wrapper macro for "assume" with an (empty) cond-expand'ed
default
definition and send this to upstream. If this change has such an impact, then
other
implementations might take advantage from type-declarations as well.
felix
- [Chicken-hackers] [PATCH] Improve irregex matching performance a lot by adding two type declarations, Peter Bex, 2015/12/08
- Re: [Chicken-hackers] [PATCH] Improve irregex matching performance a lot by adding two type declarations,
felix . winkelmann <=
- Re: [Chicken-hackers] [PATCH] Improve irregex matching performance a lot by adding two type declarations, Peter Bex, 2015/12/09
- Message not available
- Re: [Chicken-hackers] [PATCH] Improve irregex matching performance a lot by adding two type declarations, Dan Leslie, 2015/12/12
- Re: [Chicken-hackers] [PATCH] Improve irregex matching performance a lot by adding two type declarations, Peter Bex, 2015/12/12
- Re: [Chicken-hackers] [PATCH] Improve irregex matching performance a lot by adding two type declarations, John Cowan, 2015/12/12
- Re: [Chicken-hackers] [PATCH] Improve irregex matching performance a lot by adding two type declarations, Jörg F . Wittenberger, 2015/12/13
Re: [Chicken-hackers] [PATCH] Improve irregex matching performance a lot by adding two type declarations, Kooda, 2015/12/08