[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Chicken-hackers] [PATCH] A few patches for Windows

From: Peter Bex
Subject: [Chicken-hackers] [PATCH] A few patches for Windows
Date: Sat, 20 Jun 2015 15:27:26 +0200
User-agent: Mutt/1.5.21 (2010-09-15)

Hi all,

The find-files change by Mario uncovered a bug in the Windows
implementation of the posix create-directory procedure: if you
pass #t as the second argument (so it will create the parent
directory components), it will accidentally skip the first
component.  This is rarely a problem with absolute paths,
as most often you won't be creating something directly under
the root (though you could do so), but with relative paths
this means breakage happens really easily.

The attached patches fix this problem (that's patch 0001, which
should go into chicken-5, master *and* prerelease, IMO!) and
two more problems.  Patch 0002 fixes the find-files test itself
so that it will omit the symlink stuff on Windows because that's
unsupported there (should go into chicken-5 and master only),
and patch 0003 fixes the executable-pathname test on mingw-msys,
where the shell script will use forward slashes while the
executable-pathname procedure will return paths with backslashes.
This final patch should only go into chicken-5, as master does not
have this new procedure or the test.


Attachment: 0001-Fix-create-directory-parent-dir-creation-on-Windows.patch
Description: Text Data

Attachment: 0002-Skip-symlink-tests-in-find-files-test-on-Windows-whi.patch
Description: Text Data

Attachment: 0003-Fix-executable-tests-on-mingw-msys-for-path-separato.patch
Description: Text Data

Attachment: signature.asc
Description: Digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]