Re: [Chicken-hackers] [PATCH][5] Move foldable binding annotations into types.db

[Evan Hanson]

Hi Peter,

On 2014-11-16 14:12, Peter Bex wrote:
> I finally made some time to look into this (sorry for the delay!)

Likewise. :)

> In any case, right now there's an inconsistency: number->string,
> ##sys#fixnum->string and symbol->string are marked foldable, whereas
> (for example), list->string and blob->string aren't.  Whichever way
> we decide to approach this, that inconsistency should be resolve, I
> think.

Attached is a patch that makes these "->string" procedures consistently
non-foldable. I prefer to be conservative here, per our discussion on
IRC (many moons ago!): this makes it less likely that we'll unwittingly
introduce subtle bugs around string `eq?`-ity, and if we do decide to
add optimizations around collapsable string/list literals I'd prefer to
be deliberate about it and implement them in their own changeset later.

Cheers and happy new year,

Evan

0001-Make-string-procedures-non-foldable.patch
Description: Text Data