Re: [Chicken-hackers] [PATCH] Replace unsafe string functions with their safer counterparts

[Mario Domenech Goulart]

On Wed, 05 Feb 2014 23:56:11 +0000 Mario Domenech Goulart <address@hidden> 
wrote:

> On Thu, 23 Jan 2014 12:28:01 +0100 Christian Kellermann <address@hidden> 
> wrote:
>
>> I propose the following patch. It has been tested on OpenBSD and
>> Linux. Should work without troubles on all other OSes as well.
>> Please give it a try.
>
> Sorry for taking so long to give it a try on Windows.  Unfortunately, it
> seems to break things on that platform.
>
> The environment variable tests in posix-tests.scm caught the issue.
> Here's an example:
>
>   #;1> (use posix)
>   ; loading c:/local/chicken-master-mingw/lib/chicken/7/posix.import.so
>   ; ...
>   ; loading library posix ...
>   #;2> (setenv "FOO" "bar")
>   #;3> (get-environment-variable "FOO")
>   "x\x01=b\x03"
>
> Reverting 8efbbc50d050d28c34ea0c5a58d0de92ec9f918a makes tests pass
> again.  Tested on cygwin, mingw (Windows XP 32bit).

I forgot to mention that on cygwin I had to define HAVE_STRLCAT and
HAVE_STRLCPY in Makefile.cygwin, otherwise I'd get errors like
http://paste.call-cc.org/paste?id=87b50bb84351693193183e7c58f2293b6cd52148

After defining HAVE_STRLCAT and STRLCPY and rebuilding chicken, I get
the environment variables issue.

Best wishes.
Mario
-- 
http://parenteses.org/mario