[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Chicken-hackers] [PATCH] Fix #999 by swapping dependency declaratio
From: |
Mario Domenech Goulart |
Subject: |
Re: [Chicken-hackers] [PATCH] Fix #999 by swapping dependency declarations |
Date: |
Tue, 24 Sep 2013 14:27:15 +0000 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) |
On Sun, 22 Sep 2013 18:00:34 +0200 Peter Bex <address@hidden> wrote:
> Here's another stupid bug fixed. Turns out that the extras unit
> doesn't really use anything from the ports unit, so it's easily fixed.
>
> This *could* break some programs (that were already broken) where extras
> is USEd and procedures from ports are used. These should be easily
> fixed, and they were already broken in the first place, so I don't
> consider this a real issue (and the reported bug is worse; it's a
> segfault). For programs which are a module this won't cause issues.
> I've added a note to NEWS so that people will be aware why their
> programs might suddenly be failing.
>
> I expect some fallout in Salmonella, because test scripts occasionally
> forget to import ports (as even happened in chicken core itself, see
> the patch).
Thanks, Peter. I pushed your patch.
I quickly run salmonella on the top 10 eggs in the reverse dependencies
rank and on a couple of eggs which are heavy on dependencies (chickadee
and awful-sql-de-lite). Doesn't cause any breakage, as far as I can
tell. Let's wait for the next full salmonella report (tomorrow) to see
what happens.
Best wishes.
Mario
--
http://parenteses.org/mario