Re: [Chicken-hackers] [PATCH] Fix for #1014 and minor cleanup of posix{win, unix} implementations

[Peter Bex]

On Fri, May 24, 2013 at 08:27:49PM -0500, Jim Ursetto wrote:
> OK, I didn't see this because it wasn't attached to the ticket.

Sorry about that.

> I posted an alternate patch on #1014 which just addresses the "old data" 
> problem in string->time.  As far as I can tell, the various uses of C_tm can 
> not interfere with each other and all one needs to do is initialize C_tm to a 
> sane default just prior to calling strptime.  Does that look correct?

It looks correct.  However, I prefer the larger patch I made (even though
it's slightly more complex), because it gets rid of the redundant copy of
time->string from posixunix, and the duplicate macros in Windows/UNIX.
It's also cleaner than using globals, which might cause trouble later if
we ever decide to get rid of (declare (disable-interrupts))

There are also some memsets still left in the code after your patch,
so some get initialized using C_tm_init, and some using memset.

Cheers,
Peter
-- 
http://www.more-magic.net