Re: [Chicken-hackers] [PATCH] two scrutinizer fixes

[Peter Bex]

On Fri, Nov 09, 2012 at 06:04:25PM +0100, Felix wrote:
> > I messed around in the code a bit more, but was unable to come up with
> > an effective patch :(
> 
> I'll do that later, in a different patch. You can create a ticket for
> this and assign it to me if you like.

Done: #952 is yours :)

> >> b) when matching result-types, allow "undefined" to match "noreturn"
> >>    as the "noreturn" property can not be inferred for foreign procedures
> >>    (for example) in general
> > 
> > Shouldn't this only be the case when doing a non-strict type match?
> > ie, when (not exact) is true?  I admit, I'm still a little unclear on
> > how exact is supposed to work...
> 
> Strict is only required for compiler-typecase and for specialization,
> also, whether a procedure is noreturn or not has actually nothing to
> do with the type (undefined is just as good). So, I think this is ok
> (to treat "noreturn" like "undefined" here), since it's not incorrect.

OK, thanks for the explanation.

> >> Additionally, when converting the internal node tree in the compiler
> >> to expressions, internal type-declaration forms are not shown to
> >> reduce clutter in the output (this is just a cosmetic change).
> > 
> > Only in debugging mode, when the user has uncommented the define-syntax
> > that disables the debugging stuff, right?
> 
> No, it's for the code-fragments created in error messages (like
> the ones from the scrutinizer).

Ah, I misunderstood; you were of course referring to the walk invocation
for ##core#the/result in build-expression-tree.  For some reason I
thought you were referring to the 'ddd' macro.

I've now pushed this change.

Cheers,
Peter
-- 
http://sjamaan.ath.cx
--
"The process of preparing programs for a digital computer
 is especially attractive, not only because it can be economically
 and scientifically rewarding, but also because it can be an aesthetic
 experience much like composing poetry or music."
                                                        -- Donald Knuth