[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Chicken-hackers] [PATCH] validate types in compiler-typecase

From: Christian Kellermann
Subject: Re: [Chicken-hackers] [PATCH] validate types in compiler-typecase
Date: Mon, 20 Aug 2012 10:09:59 +0200
User-agent: Mutt/1.5.21 (2010-09-15)

* felix winkelmann <address@hidden> [120819 01:56]:
> > * felix winkelmann <address@hidden> [120815 21:40]:
> >> Type-specifiers given in "##core#typecase"/"compiler-typecase"
> >> forms must be validated, as the validation resolved type-aliases
> >> created with "define-type".
> >>
> >> Reported by, guess who? megane. Should fix #897.
> >
> > This fails the scrutiny test for me:
> >
> Sorry - the "fix" didn't handle the "else" case in clauses
> correctly. Attached is a new version of the patch. I also moved all
> type-validation into the expansion/canonicalization of user forms (in
> some cases this was done for "##core#..." forms). The advantage is
> more consistency and better error-reporting but code expanding into
> the core forms needs to perform type-validation (as this resolves
> type-variables). This is not needed in user code, but must be kept in
> mind for macros in the core system. The change looks more involved
> than it actually is, due to some re-factoring. All tests pass for me.

Same here, thanks for the refactoring. I have pushed it.

Be right back -- Godot.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]