[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Chicken-hackers] [PATCH] Fix #808 by not comparing strings with sta
From: |
Jim Ursetto |
Subject: |
Re: [Chicken-hackers] [PATCH] Fix #808 by not comparing strings with standard C string functions |
Date: |
Mon, 23 Apr 2012 13:00:59 -0500 |
Pushed. Also note that case-insensitive substring comparisons are affected as
well. Attached patch which fixes this and adds more tests.
0001-Also-use-C_memcasecmp-for-case-insensitive-substring.patch
Description: Binary data
On Apr 22, 2012, at 8:51 AM, Peter Bex wrote:
> Hi,
>
> Here's a fix for #808. Pretty simple, and it looks like C_string_compare
> and C_string_compare_case_insensitive are the only two places where these
> comparisons were done incorrectly.
>
> Please someone double-check if I didn't miss any.
>
> Cheers,
> Peter
> --
> http://sjamaan.ath.cx
> --
> "The process of preparing programs for a digital computer
> is especially attractive, not only because it can be economically
> and scientifically rewarding, but also because it can be an aesthetic
> experience much like composing poetry or music."
> -- Donald Knuth
> <0001-Fix-808-use-memcmp-instead-of-strncmp-for-comparing-.patch>_______________________________________________
> Chicken-hackers mailing list
> address@hidden
> https://lists.nongnu.org/mailman/listinfo/chicken-hackers