Re: [Chicken-hackers] [PATCH] Raise error on construction of too large vectors/blobs

[Christian Kellermann]

* John Cowan <address@hidden> [120304 19:41]:
> Christian Kellermann scripsit:
> 
> > +SRFI-4 vectors internally are implemented with a maximum length of
> > +0x3fffff '''bytes'''. 

Ah that is completely bogus, #xffffff (24bits) is correct.
Also that patch omits the distinction between 32bit and 64bit systems.

> That looks like the maximum *index* rather than the maximum *length*,
> which should be greater by 1.

It may look like the index but as I read the code it is the length.
or am I misreading something?

> > +* All byte vectors have a maximum number of entries of 0xffffff
> 
> That number is greater than the above number.  How can that be?

Yes, because of the error above. How does the attached correction
sound to you?

Thanks!

Christian

-- 
Who can (make) the muddy water (clear)? Let it be still, and it will
gradually become clear. Who can secure the condition of rest? Let
movement go on, and the condition of rest will gradually arise.
 -- Lao Tse.

0001-Raise-error-on-construction-of-too-large-vectors-blo.patch
Description: Text document