[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Chicken-hackers] [PATCH] add input- and output port types specifier
From: |
Felix |
Subject: |
Re: [Chicken-hackers] [PATCH] add input- and output port types specifiers |
Date: |
Fri, 30 Sep 2011 07:04:29 -0400 (EDT) |
From: Christian Kellermann <address@hidden>
Subject: Re: [Chicken-hackers] [PATCH] add input- and output port types
specifiers
Date: Fri, 30 Sep 2011 12:57:47 +0200
> * felix winkelmann <address@hidden> [110930 08:40]:
>> From: Alan Post <address@hidden>
>> Subject: Re: [Chicken-hackers] [PATCH] add input- and output port types
>> specifiers
>> Date: Thu, 29 Sep 2011 06:21:22 -0600
>
> The following hunk has nothing to do with ports but it is not used so I agree.
Ok.
> This has nothing to do with ports, what does it do?
> Should this be part of the commit?
It is just a small optimization, and I guessed it would be ok
to add it here. If you prefer, I can submit a separate patch.
> The rest looks good to me and does not break anything on my system.
> I will push it if noone objects. With or without the above hunk as you like.
Thanks. If you add the hunk, it would save me a few minutes of
fiddling with git.
cheers,
felix