[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [CASHeW-s-editor-patches] Parsing of XML and recreating diagram...

From: Andrew John Hughes
Subject: Re: [CASHeW-s-editor-patches] Parsing of XML and recreating diagram...
Date: Wed, 23 Mar 2005 11:55:09 +0000

On Wed, 2005-03-23 at 10:26 +0000, Ravish Bhagdev wrote:
> I'm committing the attached patch to recreate the Diagram object from parsed 
> XML and redraw the read diagram.  Connections still not established in the 
> recreated diagram.  Thats next step to do.
> Changelog:
> 2005-03-23  Ravish Bhagdev  address@hidden
> * src/nongnu/cashews/eclipse/model/
> (makeFromStream): Added code to recreate diagram from read model insted of 
> previously empty diagram
> * src/nongnu/cashews/eclipse/model/
> Created diagram object and new method called getDiagram added to get the 
> created diagram in parser events
> I have not finished with reading the XML file and recreate the diagram on 
> canvas.  The thing that is left is creating connections between the nodes of 
> recreated diagram objects.  Nodes are getting displayed at the set X,Y 
> positions now. (Patch attached)
> --------------------------------------------------------------------------------
> _______________________________________________
> CASHeW-s-editor-patches mailing list
> address@hidden
> _______________________________________________
> CASHeW-s-editor-patches mailing list
> address@hidden

I don't know if you're RFCing this patch or not, but:

* You still seem to be including XMLizable as a new file, when its in
current CVS.
* What is river.gif????  Can I remove it and servicecomposer from CVS?
(Binaries shouldn't really be in there anyway)
* I don't see a need to capture endDocument() -- is this not stubbed for
you in DefaultHandler?
* Can we get rid of
+ * TODO To change the template for this generated type comment go to
+ * Window - Preferences - Java - Code Style - Code Templates
+ */
which is just superfluous
* Also can you do @author Ravish Bhagdev (address@hidden) rather
than just @author Ravish which could be anyone.  You can probably set
this in Eclipse.
* A brief glance suggests that the serialization is still incorrect
(lacking quotes around attributes at least), so you will experience
problems with deserializing.
* You should start each file with the Eclipse licensing from:

You can just copy this verbatim and change the top line to reference the
current file.  You want the longer Eclipse one.

Andrew :-)

Please avoid sending me Microsoft Office (e.g. Word, PowerPoint)

No software patents in Europe --

"Value your freedom, or you will lose it, teaches history.
`Don't bother us with politics' respond those who don't want to learn."
-- Richard Stallman

Escape the Java Trap with GNU Classpath!
public class gcj extends Freedom implements Java { ... }

Attachment: signature.asc
Description: This is a digitally signed message part

reply via email to

[Prev in Thread] Current Thread [Next in Thread]