Re: [Bug-zile] Crash on file oddities fixed?

[Gary V. Vaughan]

Hi Reuben,

On Tue, Apr 12, 2011 at 08:16:00PM +0100, Reuben Thomas wrote:
> Yes, this is a sort of bug that is unfortunately possible in Lua (but
> not in C).

All the more reason for an exhaustive testsuite with good coverage :)

> I have pushed what I think is a fix.

Thanks... you forgot to patch the original bug though.  I committed
the fix, hope you don't mind.

> However, this sounds as though something doesn't work on a non-root
> mount, as it's trying to print an error!

Still looks like a fixable Lua bug to me.  HEAD now gives me two
terminal bells and a very short-lived error message flashes up in
the minibuffer:

  cannot make backup file: %s

Quickly overwritten by:

  Wrote /Users/me/.mutt/muttrc

So a few things are still wrong:

  i) posix.errno() is not returning an error message at file.lua:369
 ii) copy_file is not working at file.lua:365
iii) waitkey is not waiting for a key before overwriting the partial
     error message at file.lua:370

We're still in better shape than yesterday though, because the crash
itself no longer happens as Zile attempts to handle and diagnose the
real error itself now :)

Gotta dash!

Cheers,
-- 
Gary V. Vaughan (gary AT gnu DOT org)

pgpxig2pTfybJ.pgp
Description: PGP signature