[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-xorriso] Crash in xorriso with fix

From: Thomas Schmitt
Subject: Re: [Bug-xorriso] Crash in xorriso with fix
Date: Wed, 24 Jul 2019 09:55:48 +0200


the changes to prevent the SIGSEGV are now committed.

I decided for some modifications of your patch:

- The new variable diff_buf_wpt became size_t rather than int.

- I made sure that the buffer enlargement is big enough to surely
  take the pending input line. (Was already so, but only implicitely.)

- The new helper function went to xorriso/text_io.c and got a parameter
  by which the caller can curb the length to values smaller than
  sizeof(xorriso-info_text). (I deem a 40 KB debug message of few use.)
  The code of the function changed completely. Review is welcome.

More problems popped up:

- The test ACL text is not applicable because the user names are not
  known to the system and cannot be mapped to user ids. (Also the 10000
  user lines were mis-formatted in respect to setfacl role:name:permissions
  The error message from libisofs is too sparse
    libisofs: FAILURE : Error with encoding ACL for AAIP
  and needs to be improved.
  (And then i need a test text which really causes attribute setting of
   the file node.)

- For some reason a few characters of the initially printed 40960
  text characters of the debug message did not get printed.

Both will be investigated in the next days.

Have a nice day :)


reply via email to

[Prev in Thread] Current Thread [Next in Thread]