Re: [Bug-xorriso] [PATCH] mmc: fix static link with libcdio

[Baruch Siach]

Hi Thomas,

On Fri, Apr 21, 2017 at 08:25:55AM +0200, Thomas Schmitt wrote:
> Baruch Siach wrote:
> > libburn and libcdio define identically named symbols. This leads to static
> > link failure when building xorriso statically:
> > [...] mmc_get_configuration [...] mmc_read_cd [...] mmc_set_speed
> 
> This poses the bigger question whether all mmc_* functions should be
> renamed and even whether libburn has to care for collisions of its
> private symbols with other libraries.
> 
> Please give me some background info about the situation that led to the
> clash:
> 
> - How exactly did you configure and build xorriso ?
>   Was there any deviation from
>     ./configure --enable-libcdio && make

You can see all the details in the Buildroot autobuild log[1].

> - Which version of libcdio do you use ?

Version 0.94.

> - Is there a particular reason why you link xorriso with libcdio ?
>   Afaik, libburn has own system adapters for all operating systems where
>   libcdio can perform passthrough of SCSI commands.

In Buildroot libcdio is an optional dependency of xorriso. Whenever the user 
enables libcdio, Buildroot automatically enables[2] libcdio for xorriso. The 
autobuilder continuously tests builds of random configurations, eventually 
hitting one combination that exhibits the problem. It only happened once[3] so 
far.

A possible alternative solution for Buildroot would be to disable libcdio for 
xorriso in static builds. Do you think that would be preferable?

[1] 
http://autobuild.buildroot.net/results/a5d/a5d0f8bec0d39e48f6dfe4ecc07fe0ca3c6bd70a/build-end.log

[2] https://git.busybox.net/buildroot/tree/package/xorriso/xorriso.mk

[3] http://autobuild.buildroot.net/?reason=xorriso-1.4.6

Thanks,
baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - address@hidden - tel: +972.52.368.4656, http://www.tkos.co.il -