[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-XBoard] [bug #34991] Load engine doesn't work in localized xboa

From: Byrial Jensen
Subject: Re: [Bug-XBoard] [bug #34991] Load engine doesn't work in localized xboard
Date: Wed, 14 Dec 2011 09:07:37 +0100
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20110922 Thunderbird/3.1.15

On 14-12-2011 05:18, Arun Persaud wrote:

I added a test if strlen>0 and only call gettext in those cases... that
seems to work for me... let me know if this solves the problem.

It is not the right thing to do, because then you will still call gettext() for engine names. These may by coincidence be equal to a string with a translation, and then the engine name is changed in the combo box.

The min field of struct Option is alreday acting as a flag when the option is a combobox. I suggest adding another flag value to that field (and maybe define it as a union for clarity/documentation) to indicate when not to call gettext(). I can it do if you will accept more patches from me. I did send e-mail to FSF for registration, but their paperwork may take some time I suppose.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]