Re: unit tests fail due to extra output file wget-log

[Nam Nguyen]

Tim Rühsen writes:

> I am currently not sure how to best solve it except by not running the
> tests in the background.

I propose these two patches to the perl and python testing scripts. They
ignore wget-log. This makes the test suite more robust and these errors
go away.

--8<---------------cut here---------------start------------->8---
Index: testenv/conf/expected_files.py
--- testenv/conf/expected_files.py.orig
+++ testenv/conf/expected_files.py
@@ -27,7 +27,7 @@ class ExpectedFiles:
                 # pubring.gpg, pubring.kbx, dirmngr.conf, gpg.conf will be 
created by libgpgme
                 #   if $HOME doesn't contain the .gnupg directory.
                 # setting $HOME to CWD (in base_test.py) breaks two Metalink 
tests, so we skip this file here.
-                if name in [ 'pubring.gpg', 'pubring.kbx', 'dirmngr.conf', 
'gpg.conf' ]:
+                if name in [ 'pubring.gpg', 'pubring.kbx', 'dirmngr.conf', 
'gpg.conf', 'wget-log' ]:
                     continue
 
                 f = {'content': ''}

Index: tests/WgetTests.pm
--- tests/WgetTests.pm.orig
+++ tests/WgetTests.pm
@@ -356,7 +356,7 @@ sub _verify_download
     __dir_walk(
         q{.},
         sub {
-            if (!(exists $self->{_output}{$_[0]} || $self->{_existing}{$_[0]}))
+            if (!(exists $self->{_output}{$_[0]} || $self->{_existing}{$_[0]}) 
&& ($_[0] != "wget-log"))
             {
                 push @unexpected_downloads, $_[0];
             }
--8<---------------cut here---------------end--------------->8---

SKIP: Test-https-badcerts.px
============================================================================
Testsuite summary for wget 1.21.4
============================================================================
# TOTAL: 94
# PASS:  85
# SKIP:  9
# XFAIL: 0
# FAIL:  0
# XPASS: 0
# ERROR: 0
============================================================================

SKIP: Test-no_proxy-env.py
============================================================================
Testsuite summary for wget 1.21.4
============================================================================
# TOTAL: 45
# PASS:  44
# SKIP:  1
# XFAIL: 0
# FAIL:  0
# XPASS: 0
# ERROR: 0
============================================================================

On OpenBSD I can reproduce what you see: (OpenBSD uses OpenBSD make and
not gnu's gmake.)
- manually going to the build directory and `make check &' results in
  many errors
- same but foregrounded with `make check' results in resolving these errors
- `make test' from the ports directory /usr/ports/net/wget (not build
  directory) results in many errors