Re: Warnings on 32-bit machine

[Darshit Shah]

Hi Jeffrey,

Thanks! This happened due to some last minute cleanups we did on
portability code in Wget. I've pushed a patch that should fix these
warnings.

In the future, there are more such cleanups I intend to perform to
simplify the codebase now that Wget expects parts of C99 support everywhere.

On 06.01.21 06:38, Jeffrey Walton wrote:
> Hi Tim/Darshit,
> 
> This is from Wget 1.21 on 32-bit hardware.
> 
> retr.c: In function 'fd_read_body':
> retr.c:498:35: warning: format '%ld' expects argument of type 'long
> int', but argument 2 has type 'wgint {aka long long int}' [-Wformat=]
>                            DEBUGP(("zlib stream ended unexpectedly after "
>                                    ^
> wget.h:129:54: note: in definition of macro 'DEBUGP'
>  #define DEBUGP(args) do { IF_DEBUG { debug_logprintf args; } } while (0)
>                                                       ^~~~
> retr.c:499:38: note: format string is defined here
>                                    "%ld/%ld bytes\n", sum_read, toread));
>                                     ~~^
>                                     %lld
> In file included from retr.c:31:0:
> retr.c:498:35: warning: format '%ld' expects argument of type 'long
> int', but argument 3 has type 'wgint {aka long long int}' [-Wformat=]
>                            DEBUGP(("zlib stream ended unexpectedly after "
>                                    ^
> wget.h:129:54: note: in definition of macro 'DEBUGP'
>  #define DEBUGP(args) do { IF_DEBUG { debug_logprintf args; } } while (0)
>                                                       ^~~~
> retr.c:499:42: note: format string is defined here
>                                    "%ld/%ld bytes\n", sum_read, toread));
>                                         ~~^
>                                         %lld
> In file included from retr.c:31:0:
> retr.c:591:19: warning: format '%ld' expects argument of type 'long
> int', but argument 3 has type 'wgint {aka long long int}' [-Wformat=]
>            DEBUGP(("zlib read size differs from raw read size (%lu/%ld)\n",
>                    ^
> wget.h:129:54: note: in definition of macro 'DEBUGP'
>  #define DEBUGP(args) do { IF_DEBUG { debug_logprintf args; } } while (0)
>                                                       ^~~~
> 
> Jeff
> 
>