Re: [Bug-wget] Implementing draft to update RFC6265

[Kushagra Singh]

I figured out the mistake, I guess. The cookie was getting expired and
wasn't getting saved to the file. I added --keep-session-cookies to
WGET_OPTIONS, now I can see the cookies being saved in the file.

In the test, I am removing the first 4 lines of the cookie file (which WGET
generates) and then saving it again. Since no cookie should exist (in this
case), I am comparing it to an empty file using the ExpectedFiles hook.

Without the patch (0003), the test shouldn't pass, as the secure cookie is
set. Although there is an error raised "Error: Contents of mycookies.wget
do not match." in the test log, the test suit doesn't fail explicitly. Is
this supposed to happen?

After applying the patch (0003), the error is no longer raised in the log.

Patches and test log are attached.

Thank you,
Kushagra

Test-reject-secure-cookie.log
Description: Text Data

0002-Added-test-rejects-setting-a-secure-cookie-over-a-no.patch
Description: Text Data

0001-Updated-expected_files-hook-to-allow-passing-a-funct.patch
Description: Text Data

0003-Added-recommendations-from-draft-West.patch
Description: Text Data