On 04/21/2015 04:19 PM, Darshit Shah wrote:
Regarding the patch itself, I wanted to ask if it would not be cleaner to dig
into the code and replace every call to url_unescape with the new prototype? In
my opinion that would help in maintaining readability and more importantly
maintainability of the code.
I thought of it too, and I agree with you. The reason I haven't done it is
because I'm not really sure whether all the functions that call url_unescape
need the reserved characters escaped or not. I believe there'll be no problems,
but I didn't want to just blindly replace all the calls to url_unescape without
even having a quick look, which is exactly what I didn't have time to do so
far. What do you guys think?
I'll have a closer look as soon as I can (and provided no one does it before)
and roll another patch with the replacements. Unless of course someone already
knows the answer.
Regarding the patches, I resend them with the changes made according to your
feedback.
Changes made so far:
- Merged the prototype patch into 1.
- Shortened commit messages.
- New test added to Makefile.am (in patch 2).