bug-wget
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-wget] Memory leak in idn_encode; Valgrind suppression file


From: Hubert Tarasiuk
Subject: Re: [Bug-wget] Memory leak in idn_encode; Valgrind suppression file
Date: Mon, 06 Apr 2015 22:15:36 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0

W dniu 06.04.2015 o 21:25, Ángel González pisze:
> I agree it is helpful to name them differently. What about this
> alternative rename?
It has the advantage of unconditional `xfree`, but the call to
`idna_to_ascii_8z` is more complicated. It is hard to tell which one is
better.

> (I'm the host reassignation by using a ternary, plus touched a comment)
We should probably also fix this comment:
>        /* sXXXav : free new when needed ! */
As it presumably mentions the problem that we are going to repair.


Regards,
Hubert

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]