[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-wget] [PATCH] remote_to_utf8: cut off part of condition always
From: |
Jakub Cajka |
Subject: |
Re: [Bug-wget] [PATCH] remote_to_utf8: cut off part of condition always false |
Date: |
Fri, 21 Nov 2014 03:45:42 -0500 (EST) |
Hello,
please, note that this change(commit 1553c70961d05ffeb15780d0d1d58f991d9a6c66)
breaks wget on platforms(arm, ppc, s390...) with unsigned char, as assuming
that char is signed is wrong(C standard is not specifying sign of char...
http://stackoverflow.com/questions/2054939/is-char-signed-or-unsigned-by-default).
This got fixed recently(commit 981c7456ff6d8d583a39d43b78173bd0bdd7ce99)...
see change log, or my e-mail to this ML with original patch from November 3,
2014. Please revert commit 1553c70961d05ffeb15780d0d1d58f991d9a6c66.
Best regards,
Jakub Čajka
----- Original Message -----
From: "Darshit Shah" <address@hidden>
To: "Daniel Stenberg" <address@hidden>
Cc: address@hidden
Sent: Friday, November 21, 2014 9:26:01 AM
Subject: Re: [Bug-wget] [PATCH] remote_to_utf8: cut off part of condition
always false
On 11/21, Daniel Stenberg wrote:
>Hey
>
>Attached is a tiny patch that fixes a compiler warning as the right
>part of the condition always evaluates to true when a signed char is
>checked if it is larger than 127.
>
Some would term this as defensive programming. Though I think if a signed char
were to exceed 127 for any reason, such checks will be the least of the
problems
for Wget.
I pushed this patch after adding the required ChangeLog entry. (Another ancient
relic, I want to get rid of)
--
Thanking You,
Darshit Shah
- Re: [Bug-wget] ARRG (was: remote_to_utf8: cut off part of condition always false), (continued)
- Re: [Bug-wget] ARRG (was: remote_to_utf8: cut off part of condition always false), Tim Ruehsen, 2014/11/21
- Re: [Bug-wget] ARRG (was: remote_to_utf8: cut off part of condition always false), Darshit Shah, 2014/11/21
- Re: [Bug-wget] ARRG (was: remote_to_utf8: cut off part of condition always false), Jakub Cajka, 2014/11/21
- Re: [Bug-wget] ARRG (was: remote_to_utf8: cut off part of condition always false), Daniel Stenberg, 2014/11/21
- Re: [Bug-wget] ARRG (was: remote_to_utf8: cut off part of condition always false), Tim Ruehsen, 2014/11/21
- Re: [Bug-wget] ARRG (was: remote_to_utf8: cut off part of condition always false), Daniel Stenberg, 2014/11/21
- Re: [Bug-wget] ARRG (was: remote_to_utf8: cut off part of condition always false), Tim Ruehsen, 2014/11/21
- Re: [Bug-wget] ARRG (was: remote_to_utf8: cut off part of condition always false), Daniel Stenberg, 2014/11/21
- Re: [Bug-wget] ARRG (was: remote_to_utf8: cut off part of condition always false), Tim Ruehsen, 2014/11/21
- Re: [Bug-wget] ARRG (was: remote_to_utf8: cut off part of condition always false), Jakub Cajka, 2014/11/21
Re: [Bug-wget] [PATCH] remote_to_utf8: cut off part of condition always false,
Jakub Cajka <=