[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-wget] Removing form feeds from sources
From: |
Giuseppe Scrivano |
Subject: |
Re: [Bug-wget] Removing form feeds from sources |
Date: |
Thu, 20 Nov 2014 12:12:59 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
Tim Ruehsen <address@hidden> writes:
> On Wednesday 19 November 2014 23:36:40 Daniel Stenberg wrote:
>> On Wed, 19 Nov 2014, Tim Rühsen wrote:
>> > I won't change my toolchain just to see these formfeeds. Looks like I had
>> > luck so far... but now, really, how can I work on Wget's sources from now
>> > on ? I have to stop here and now...
>>
>> Stop with that crap (formfeed characters) already. Exactly zero people
>> actually need those things in source code, which is also why no modern
>> projects use them anywhere. They're not helpful these days.
>>
>> Also, the GNU code guidelines say this[1]: "Please use formfeed characters
>> (control-L) to divide the program into pages at logical places". It does not
>> say that they are mandatory or that you'll be run out of the village if you
>> don't use them.
>>
>> Code guidelines are supposed to *help*!
>>
>> [1] = end of the section at
>> http://www.gnu.org/prep/standards/standards.html#Formatting
>
> If everybody agrees, I would like to remove the form feeds once and for all.
> Attached is a patch.
>
> FYI:
> to count form feeds
> grep -c `echo -e "\014"` <filename>
>
> to remove form feeds
> sed -i 's/'`echo -e "\014"`'//g' <filename>
>
> Tim
>
> From 18324828a4107b9f33b72ce9fcf7d7b8858d73f6 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Tim=20R=C3=BChsen?= <address@hidden>
> Date: Thu, 20 Nov 2014 11:56:05 +0100
> Subject: [PATCH] Removed form feeds from sources and NEWS
>
> ---
> ChangeLog | 4 ++++
> NEWS | 70
> ++++++++++++++++++++++++++++----------------------------
> src/ChangeLog | 4 ++++
> src/cmpt.c | 8 +++----
> src/connect.c | 12 +++++-----
> src/convert.c | 6 ++---
> src/cookies.c | 18 +++++++--------
> src/ftp-basic.c | 2 +-
> src/ftp-ls.c | 2 +-
> src/hash.c | 4 ++--
> src/host.c | 10 ++++----
> src/html-parse.c | 8 +++----
> src/html-url.c | 4 ++--
> src/http-ntlm.c | 4 ++--
> src/http.c | 16 ++++++-------
> src/init.c | 12 +++++-----
> src/log.c | 14 ++++++------
> src/main.c | 4 ++--
> src/mswindows.c | 4 ++--
> src/progress.c | 4 ++--
> src/ptimer.c | 2 +-
> src/recur.c | 4 ++--
> src/res.c | 14 ++++++------
> src/retr.c | 8 +++----
> src/spider.c | 2 +-
> src/url.c | 24 +++++++++----------
> src/utils.c | 28 +++++++++++------------
> src/wget.h | 2 +-
> 28 files changed, 151 insertions(+), 143 deletions(-)
>
if make syntax-check passes without problems, feel free to push it.
Thanks,
Giuseppe
- Re: [Bug-wget] [PATCH] Fix possible issues running in a turkish locale, (continued)
- Re: [Bug-wget] [PATCH] Fix possible issues running in a turkish locale, Tim Rühsen, 2014/11/19
- Re: [Bug-wget] [PATCH] Fix possible issues running in a turkish locale, Darshit Shah, 2014/11/19
- Re: [Bug-wget] [PATCH] Fix possible issues running in a turkish locale, Tim Rühsen, 2014/11/19
- Re: [Bug-wget] [PATCH] Fix possible issues running in a turkish locale, Daniel Stenberg, 2014/11/19
- Re: [Bug-wget] [PATCH] Fix possible issues running in a turkish locale, Darshit Shah, 2014/11/20
- Re: [Bug-wget] [PATCH] Fix possible issues running in a turkish locale, Ángel González, 2014/11/20
- Re: [Bug-wget] [PATCH] Fix possible issues running in a turkish locale, Darshit Shah, 2014/11/20
- Re: [Bug-wget] [PATCH] Fix possible issues running in a turkish locale, Tim Ruehsen, 2014/11/20
- Re: [Bug-wget] [PATCH] Fix possible issues running in a turkish locale, Giuseppe Scrivano, 2014/11/20
- Re: [Bug-wget] Removing form feeds from sources, Tim Ruehsen, 2014/11/20
- Re: [Bug-wget] Removing form feeds from sources,
Giuseppe Scrivano <=
- Re: [Bug-wget] Removing form feeds from sources, Tim Ruehsen, 2014/11/20
- Re: [Bug-wget] Removing form feeds from sources, Darshit Shah, 2014/11/21
Re: [Bug-wget] [PATCH] Fix possible issues running in a turkish locale, Ángel González, 2014/11/19