|
From: | Ángel González |
Subject: | Re: [Bug-wget] [PATCH] First |
Date: | Wed, 19 Nov 2014 23:56:59 +0100 |
User-agent: | Thunderbird |
On 18/11/14 12:53, Tim Ruehsen wrote:
On Tuesday 18 November 2014 12:08:58 Giuseppe Scrivano wrote:There are many other places in Wget where we should use these functions. (See my email from 24.9.2014 13:08:21). I am not sure (in fact I doubt) that we can blindly replace strcasecmp and strncasecmp. So I try to make test cases to prove replacing is correct. What do you think ? I think the patch looks fine, and when other cases show up, we can replace the failing part with the c_ function from gnulib, as you said we can't blindly replace all occurrences.
Actually, I think we can :)Excepting perhaps init.c, all .c files at src/ are in fact expecting a C-locale str(n)casecmp
(they all deal with network protocols).Note 1: We have strcasecmp and strncasecmp functions in src/cmpt.c that could be removed.
Note 2: As gnulib is providing them, the mswindows.h defining would be unnecessary.
[Prev in Thread] | Current Thread | [Next in Thread] |