[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-wget] [PATCH] Stylistic and idiomatic cleanups in Perl tests
From: |
Pär Karlsson |
Subject: |
Re: [Bug-wget] [PATCH] Stylistic and idiomatic cleanups in Perl tests |
Date: |
Sun, 2 Nov 2014 21:31:50 +0100 |
I realized I got rid of one warning only to produce another in the test
suite.
The issue was the syntax of the eval statement in WgetFeature.pm that
essentially does what we want, but that produces a warning about using a
string or array in void context (meaning it should't normally do something,
except that we are doing in in an eval() ).
Changed the eval into a proper string eval, which stops the warning.
Sorry, about the messup!
Best regards,
/Pär
2014-11-01 18:13 GMT+01:00 Darshit Shah <address@hidden>:
> On 11/01, Pär Karlsson wrote:
>
>> Sorry, my bad. :-/ Amended in new patch attached.
>>
>
> Pushed. Thanks for the contribution!
>
>
>
> --
> Thanking You,
> Darshit Shah
>
0001-Fixed-eval-syntax-that-generated-unnecessary-warning.patch
Description: Text Data