Re: [Bug-wget] [PATCH] Using parallel test harness

[Tim Ruehsen]

On Thursday 25 September 2014 18:45:11 Darshit Shah wrote:
> > Yes - definitely. There are Wget bugs that come out only when running the
> > tests with a different locale than C. The test suite should be fixed so
> > that it works for any non-developer who downloads the source, compiles
> > and tests it (make check). These people want to know that Wget correctly
> > works on their system which also includes their current locale. But this
> > at a later time.
> > 
> > Right now, by default the tests run with LC_ALL=C. This can only be
> > changed by setting TESTS_ENVIRONMENT. So for the moment, nothing changes
> > for anybody by default. Though developers now have the possibility to use
> > TESTS_ENVIRONMENT which doesn't work for the old serial test suite.
> > 
> > At least here, I still get english messages from the test suite, even with
> > 
> >     TESTS_ENVIRONMENT="LC_ALL=tr_TR.utf8" make check -j4
> > 
> > (is it LC_MESSAGES still being en_US.UTF-8 ? have to make some tests...)
> > 
> > Of course, should the test suite messages be english - that is what people
> > send to the developers.
> 
> That is exactly what I intended. The test suite messages should be in
> English. Now I better understand your patch and the motivation for it.
> Thanks!
> 
> In this case, yes, we should work towards ensuring that the test suite works
> properly in when the TESTS_ENVIRONMENT variable is set. I'll look into how
> this is done in the Python based tests too.
> 
> > patch version #3 is attached
> 
> I haven't tested the patch, but I guess it shouldn't be a problem.
> 
> On the topic of the Perl-based test suite, I've noticed that it has quite a
> few memory leaks. I haven't investigated to check whether the leaks are
> from Perl or the test suite implementation, but Valgrind tends to show
> memory leaks for almost all tests. We should either fix this or report the
> issue upstream. It would also allow this test suite to use the
> VALGRIND_TESTS variable that the Python based test suite is currently using
> for running all the tests through valgrind.

That should be easy. I suggest don't mix this into my patch.

If you track that down, maybe you could open another discussion thread ?

BTW, supporting valgrind should be easy going once this patch is accepted.
The question is, what do you want to check ? Wget, Perl or the test suite 
implementation ? ;-)
Testing Perl or the test suite impl seems OT here.
And for Wget we know that it eats more and more memory while running. When 
finished, it is faster not to explicitly free() all allocated memory. What 
exactly do you want to test then ?

Tim

signature.asc
Description: This is a digitally signed message part.