Re: [Bug-wget] Overly permissive hostname matching

[Ángel González]

On 19/03/14 16:37, Jeffrey Walton wrote:
> On Wed, Mar 19, 2014 at 11:30 AM, Daniel Stenberg<address@hidden>  wrote:
> > On Wed, 19 Mar 2014, Jeffrey Walton wrote:
> >
> > > # Remove lines that begin with "!"
> >
> > That sounds wrong:
> >
> >    A rule may begin with a "!" (exclamation mark). If it does, it is labelled
> >    as a "exception rule" and then treated as if the exclamation mark is not
> > present.
> Oh well. I'm too aggressive on the ban. I'd rather fail closed than open :)
>
> Anyway, I'll try to find the meaning of that bang. I seem to recall I
> could not find the meaning of it in the past.
>
> Jeff
It excludes a hostname from a previous matching rule. See 
http://publicsuffix.org/list/#list-format
Currently, there doesn't seem to be any exclusion with a wildcard, so 
right now all lines beginning
with '!' are equivalent to "accept this hostname".

Also note that by removing the "*." from the beginning of the lines*, 
you are acepting more hosts than
you should, such as a certificate for *.com.bd (represented as *.bd in 
the PSL) which should have been
rejected.



* Your script comments are wrong btw, since you're not removing full lines.