Re: [Bug-wget] [GSoC Proposal] Python3-based FTP Server for Test Suit and Test Suit Refactoring

[Darshit Shah]

Hi Zihang,

There's some improvements, but some of the areas are still missing.

Can we have a discussion sometime on IRC regarding the same?


On Fri, Mar 14, 2014 at 5:29 PM, 陈子杭 (Zihang Chen) <address@hidden> wrote:
> Hi, Darshit.
>
> Thanks a lot for the advice. Just updated the proposal hosted on gist.
>
> https://gist.github.com/mad4alcohol/9487859
>
>
> 2014-03-14 21:03 GMT+08:00 Darshit Shah <address@hidden>:
>
>> On Fri, Mar 14, 2014 at 1:54 PM, Darshit Shah <address@hidden> wrote:
>> > On Wed, Mar 12, 2014 at 3:53 AM, 陈子杭 (Zihang Chen) <address@hidden>
>> > wrote:
>> >> Hi.
>> >>
>> >> I just uploaded my proposal for GSoC 2014 on melange. Looking forward
>> >> to
>> >> your feedback :)
>> >>
>> > You should preferably mark it public, and give a link here, so that
>> > everyone, even
>> > those not registered on melange can read and review your proposal.
>> >
>> > ================ Proposal Review ===============================
>> >
>> > Your summary seems fine. You could expand on the deliverables a little
>> > more.
>> > What is suggest is you separate the deliverables from the plan and
>> > technical
>> > details. What will you deliver? That is what should come there, not
>> > *how*.
>> >
>> > You can/should explain the how as a subsection under your plan. Also,
>> > what library do you intend to use? And how?
>> >
>> > In the summary and plan you state you wish to refactor the current code.
>> > But
>> > you provide no idea at all about what is wrong and how you plan to fix
>> > it.
>> >
>> > I found your timeline lacking in a few aspects:
>> > 1. The final selections are announced on 21st April. Your timeline
>> > starts on 19th
>> > May.
>> > 2. What do you plan on doing between now and 21st April?
>> > 3. The community bonding period is an important part of the program.
>> > It is completely
>> > missing in your proposal.
>> > 4. You are already working on, and have almost completed the
>> > refactoring patchset. I
>> > don't see why you'd need 2 weeks to refactor it more. If you have any
>> > further plans
>> > about changes, you should state them in the proposal.
>> > 5. I don't see the point of spending one week of coding time in making a
>> > design
>> > document. This is should be ready before coding begins.
>> > 6. I'm glad you're upfront about your exams midway through the program.
>> > We can
>> > work around it without any hiccups.
>> >
>> > Speaking through experience, I'm not so sure if having a part-time
>> > internship
>> > simultaneously along with GSoC is a good idea. It usually takes a lot
>> > more
>> > time than you expect right now. And neither will your internship be
>> > any easier on
>> > you. In the end, you will either forego one for the other, or end up
>> > sick.
>> >
>> > Also, in my opinion your timeline needs some more thought and work. And,
>> > again,
>> > from experience, make it fine grained. Think more about each step and
>> > you'll find
>> > you've missed something, or the times just don't add up correctly.
>> >
>> > Usually, slots of 2 weeks are preferred. That also matches the timeline
>> > you
>> > suggest for discussing things over with your mentor.
>> >
>> > As suggested in the FAQ, you should really keep the time between
>> > suggested
>> > down and firm pencils down to clean up your code and wrap things up. You
>> > *will* need, and I repeat, you *will* need the whole week to wrap up
>> > and get your
>> > code ready for merging.
>> >
>>
>> Also, please edit your title to reflect which project you're applying
>> for, i.e. Wget
>> in the beginning. GNU has lots of projects and it should be easy to spot
>> which
>> ones are for Wget.
>>
>>
>> --
>> Thanking You,
>> Darshit Shah
>
>
>
>
> --
> Regards,
> Chen Zihang,
> Computer School of Wuhan University
> ---
> 此致
> 陈子杭
> 武汉大学计算机学院
>



-- 
Thanking You,
Darshit Shah