[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-wget] [Bug-Wget][PATCH] Turn --debug into no-op without debuggi
From: |
Giuseppe Scrivano |
Subject: |
Re: [Bug-wget] [Bug-Wget][PATCH] Turn --debug into no-op without debugging support. |
Date: |
Sat, 01 Feb 2014 11:50:43 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
Darshit Shah <address@hidden> writes:
> On Tue, Jan 28, 2014 at 10:58 PM, Ángel González <address@hidden>
> wrote:
>> On 28/01/14 20:15, Darshit Shah wrote:
>>> We would Wget to silently ignore the --debug flag if it is passed
>>> to it and
>>> the executable was compiled without debugging support.
>>>
>>> This is required so that existing commands / scripts that call the
>>> --debug
>>> flag will still work.
>>>
>>> I am attaching a patch which will cause Wget to turn the --debug
>>> flag into
>>> a no-op on non-debugging systems.
>>>
>> Shouldn't it print a message saying that --debug is not available
>> for this build?
>>
> Attached a new patch with the output statement
>
> From 3a62b82d1844ccd6134ad6fbc6852103af6a776c Mon Sep 17 00:00:00 2001
> From: Darshit Shah <address@hidden>
> Date: Sat, 1 Feb 2014 10:46:30 +0100
> Subject: [PATCH] Turn --debug into no-op if compiled without debugging support
>
> ---
> src/ChangeLog | 10 ++++++++++
> src/init.c | 2 --
> src/main.c | 24 +++++++++++++++---------
> src/options.h | 2 --
> 4 files changed, 25 insertions(+), 13 deletions(-)
thanks for the patch. I've just applied it.
Giuseppe