Re: [Bug-wget] NTLM auth broken in 1.13.4

[Tim Rühsen]

Am Montag, 15. Juli 2013, 13:07:08 schrieb Tom Merriam:
> On 07/15/2013 11:19 AM, Tim Rühsen wrote:
> > Am Montag, 15. Juli 2013, 09:50:27 schrieb Tom Merriam:
> >> On 07/13/2013 08:00 AM, Tim Rühsen wrote:
> >>> Am Mittwoch, 10. Juli 2013 schrieb Hrvoje Niksic:
> >>>> The NTLM code kindly donated by Daniel has always required OpenSSL.
> >>>> configure.ac says:
> >>>> 
> >>>> Updating the code to also support GNU/TLS appears straightforward.
> >>> 
> >>> Here is a (quick) patch for testing using libnettle (which GnuTLS relies
> >>> on
> >>> anyway).
> >>> I can't test it myself since lack of an NTLM capable server.
> >>> 
> >>> Please could anyone test it and review it, especially the configure.ac
> >>> stuff which is not one of my strengths.
> >>> Do we need to mention libnettle somewhere in the docs ?
> >>> 
> >>> Regards, Tim
> >> 
> >> I applied this patch to 1.13.4 and built with configure & make but it
> >> didn't work. I still get the same 'unknown authentication scheme' error.
> >> 
> >> Does wget need to be built differently for this to work?
> > 
> > Thanks, Tom.
> > 
> > src/config.h should contain the lines
> > 
> >     #define ENABLE_NTLM 1
> > 
> > and
> > 
> >     #define WITH_NETTLE 1
> > 
> > Maybe 1.13.4 ./configure needs explicitely --with-ssl=gnutls --with-ntlm.
> > 
> > src/wget --version printout:
> > GNU Wget 1.14.61-5862-dirty built on linux-gnu.
> > 
> > +digest +https +ipv6 +iri +large-file +nls +ntlm +opie +ssl/gnutls
> > ...
> > 
> > should look similar to the above line. Important is +ntlm, +ssl/gnutls and
> > I guess +digest.
> > 
> > Regards, Tim
> 
> My mistake, I was building 1.14 above
> 
> When built with configure & make (with that patch):
> 
> GNU Wget 1.14 built on linux-gnu.
> 
> +digest +https +ipv6 -iri +large-file +nls -ntlm +opie +ssl/gnutls
> 
> Wgetrc:
>     /usr/local/etc/wgetrc (system)
> Locale: /usr/local/share/locale
> Compile: gcc -DHAVE_CONFIG_H -DSYSTEM_WGETRC="/usr/local/etc/wgetrc"
>     -DLOCALEDIR="/usr/local/share/locale" -I. -I../lib -I../lib -O2
>     -Wall
> Link: gcc -O2 -Wall -lgnutls -lgcrypt -lgpg-error -lz -lz -lrt ftp-opie.o
>     gnutls.o ../lib/libgnu.a
> 
> I downloaded 1.13.4 and applied the patch and built with configure
> --with-ssl=gnutls --enable-ntlm && make
> (configure doesn't accept --with-ntlm)
> 
> I don't see WITH_NETTLE in config.h and the build fails with:
> 
> configure: error: NTLM authorization requested and OpenSSL not found;
> aborting
> 
> Am I applying the patch incorrectly or against the wrong version?


Hi Tom,

Wget 1.14 is perfect.

> I don't see WITH_NETTLE in config.h and the build fails with:
> configure: error: NTLM authorization requested and OpenSSL not found;
> aborting

Sorry, I forgot to say: after patching, you should first call
        autoreconf
to create a new version of configure.
After that you do a ./configure.


If it still does not work:

Either this comes because you don't have libnettle-dev installed (ls -la 
/usr/include/nettle should show up with a bunch of header files).

Or you did not apply the first part of the patch (configure.ac).


Regards, Tim

signature.asc
Description: This is a digitally signed message part.