[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Bug-vc-dwim] handling of new files

From: Bruno Haible
Subject: [Bug-vc-dwim] handling of new files
Date: Sun, 9 Oct 2011 01:24:03 +0200
User-agent: KMail/1.13.6 (Linux/; KDE/4.6.0; x86_64; ; )

Hi Jim,

I'm now routinely using vc-dwim for my gnulib commits, and it saves
me considerable time, compared to the previous procedure:
  - copy the top line into the Emacs buffer.
  - Add a newline.
  - copy the remaining lines into the Emacs buffer, starting with '*'.
  - remove the two spaces in front of each line.
  - Ctrl-X Ctrl-C

Just one suggestion: When the ChangeLog entry like this one

        New module 'tanhf'.
        * lib/math.in.h (tanhf): New declaration.
        * lib/tanhf.c: New file.
        * m4/tanhf.m4: New file.
        * m4/math_h.m4 (gl_MATH_H): Test whether tanhf is declared.
        * modules/math (Makefile.am): Substitute GNULIB_TANHF, HAVE_TANHF.
        * modules/tanhf: New file.
        * tests/test-math-c++.cc: Check the declaration of tanhf.
        * doc/posix-functions/tanhf.texi: Mention the new module.

mentions 3 new files, and the files exist on the file system,
"vc-dwim --commit" tells me that I should "git add" the files.
Couldn't vc-dwim do that for me?

I mean,
  - I have written the files.
  - I have listed them in the ChangeLog entry.
  - "vc-dwim --commit" should do the rest.

Maybe, for reliability (in order to avoid committing unintended files)
vc-dwim should do this only when the ChangeLog line says "New file",
but not for other messages like
      * lib/foo.c: Untabify.
      * lib/bar.c: Likewise.

In memoriam Engin Ceber <http://en.wikipedia.org/wiki/Engin_Ceber>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]