[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Bug: --output option leaves open fd in child process

From: Petr Pisar
Subject: Re: Bug: --output option leaves open fd in child process
Date: Mon, 16 Nov 2020 18:12:25 +0100

On Wed, Nov 11, 2020 at 02:26:14PM +0100, Petr Pisar wrote:
> On Fri, Nov 06, 2020 at 08:10:01PM -0700, Ed Santiago wrote:
> > Patch enclosed. Untested, because I can't get the bootstrap
> > process working and it's late at night for me. I assume if
> > it doesn't work, someone else can do a better job of it.
> > 
> I confirm that the bug exists, that the patch applies to 1.9 release, and that
> it fixes the issue properly.
Well, it turned out the patch is wrong. A correct condition for closing the
descriptor is if it differs from stderr I/O stream. The variable is
initialized to stderr. Not to NULL. Otherwise a second descriptor would be
closed if no --output option is specified.

-- Petr

Attachment: time-1.9-Close-outfp-before-exec.patch
Description: Text document

Attachment: signature.asc
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]