Re: [PATCH] install-info: fix delete dir file section code

[John Wheeler]

On 3/26/23 13:28, John Wheeler wrote:
> Attached is a revised patch that addresses your concern.  With
> this patch deleting a section will remove all preceding blank
> lines.  This change required changing file ii-0047-expected-dir-file
> to remove the extra blank line at the end of the file.
>
> I added test cases to check for correct behavior in the case you
> pointed out and when deleting the last section: of the dir file and
> of a non-terminal node in the dir file.
>
> The one feature of this change that may raise an issue is in
> case someone has used blank entry comment lines to create
> a large vertical space between one dir section and the next. This
> change will remove the extra blank lines if the following section
> is removed.  Examples of this behavior can be seen in tests
> ii-0060-test and ii-0061-test.
>
> Your thoughts?
>
> Thank you,
> John


Have you had a moment to consider this patch?

I can easily revise the patch to delete only the one preceding
blank line, and then only in those cases when it is in fact blank.

Please let me know what you would like. I will adjust to suit you.

I realize this is sort of a nit to be concerned with.  That is
why I am trying to submit a solution you only have to approve and
incorporate.  This nit bothers me because the build process I
have to work with installs, removes and re-installs the project
info files multiple times each time the project is build.

Thank you,

John