Re: Link failure

[Gavin Smith]

On Wed, Nov 24, 2021 at 09:56:00AM -0500, Ken Brown wrote:
> Building the current git HEAD on Cygwin (and probably some other platforms)
> fails with link errors:
> 
> libtool: link: gcc -shared  .libs/MiscXS.o .libs/misc.o
> -L/usr/lib/perl5/5.32/x86_64-cygwin-threads/CORE -lperl  -ggdb -O2
> -fstack-protector-strong -O3   -o .libs/MiscXS.dll
> -Wl,--enable-auto-image-base -Xlinker --out-implib -Xlinker
> .libs/MiscXS.dll.a
> /usr/lib/gcc/x86_64-pc-cygwin/11/../../../../x86_64-pc-cygwin/bin/ld:
> .libs/misc.o: in function `xs_abort_empty_line':
> /home/kbrown/src/texinfo/tp/Texinfo/XS/misc.c:74: undefined reference to 
> `rpl_free'
> /usr/lib/gcc/x86_64-pc-cygwin/11/../../../../x86_64-pc-cygwin/bin/ld:
> .libs/misc.o: in function `xs_merge_text':
> /home/kbrown/src/texinfo/tp/Texinfo/XS/misc.c:261: undefined reference to 
> `rpl_free'
> 
> The following patch fixes it:
> 
> diff --git a/tp/Texinfo/XS/Makefile.am b/tp/Texinfo/XS/Makefile.am
> index 999fda1ff5..624983939c 100644
> --- a/tp/Texinfo/XS/Makefile.am
> +++ b/tp/Texinfo/XS/Makefile.am
> @@ -53,6 +53,7 @@ TestXS_la_SOURCES = TestXS.c ppport.h
> 
>  xs_LTLIBRARIES += MiscXS.la
>  MiscXS_la_SOURCES = MiscXS.c misc.c miscxs.h ppport.h
> +MiscXS_la_LIBADD = $(builddir)/gnulib/lib/libgnu.la
> 
> 
>  # TestXS.la has to be included in xs_LIBRARIES, and not noinst_LIBRARIES,
> 
> Ken
> 

Thank you, committed in e9b0cbd6b5.