[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [platform-testers] texinfo-6.6.90 pretest
From: |
Eli Zaretskii |
Subject: |
Re: [platform-testers] texinfo-6.6.90 pretest |
Date: |
Tue, 17 Sep 2019 21:39:41 +0300 |
> From: Hans-Bernhard Bröker <address@hidden>
> Date: Tue, 17 Sep 2019 20:23:43 +0200
> Cc: Texinfo <address@hidden>
>
> The call patterns in question,
>
> strncat(dest, src, strlen(src));
> strncat(dest, "ab", 2);
>
> are absolutely equivalent to the simpler
>
> strcat(dest, src);
> strcat(dest, "ab");
>
> Using strncat() like that offers no benefit at all. So why even bother
> with the extra verbiage of using the 'n' version?
Some of the strncat calls in that file don't copy complete strings,
though, and they still cause warnings.