[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-tar] POSIX_ARCHIVE & big sparse files (>= 2^33 B excluding hole
|
From: |
Paul Eggert |
|
Subject: |
Re: [Bug-tar] POSIX_ARCHIVE & big sparse files (>= 2^33 B excluding holes) |
|
Date: |
Mon, 28 Jan 2013 14:30:04 -0800 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 |
On 01/28/13 08:40, Pavel Raiskup wrote:
> + if (u > st->stat.st_size)
> + /* Do *not* overwrite stat.st_size when it has been set by
> + GNU.sparse.realsize (func sparse_size_decoder) already. */
> + st->stat.st_size = u;
Hmm, this doesn't feel right. Can't the sparse size be greater than
the real size, in some (unusual) cases? We should overwrite
the size when realsize has not been specified, not just when
our size exceeds what's in st_size.