Re: [Bug-tar] Warning or error at failed close?

[Vebjorn Ljosa]

Paul Eggert <address@hidden> writes:

> Vebjorn Ljosa <address@hidden> writes:
>
>> Shouldn't tar exit with non-zero when close fails?
>
> Yes, that should be the right thing to do, typically.  Tar may not
> exit right away, but when it does exit it should exit with nonzero
> status if there was trouble like that.

All right, here's the one-line patch against tar-1.19.  Hope it can
make it into the next version.

Thanks,
Vebjorn


--- tar-1.19/src/buffer.c~      2007-08-26 04:56:55.000000000 -0400
+++ tar-1.19/src/buffer.c       2007-11-29 15:27:50.000000000 -0500
@@ -857,7 +857,7 @@
     verify_volume ();
 
   if (rmtclose (archive) != 0)
-    close_warn (*archive_name_cursor);
+    close_error (*archive_name_cursor);
 
   sys_wait_for_child (child_pid);