[Bug-tar] Re: segmentation fault in 1.15.91-20060523 with incremental backups creation

[Paul Eggert]

Thanks for fixing this.  Would the following patch be a bit clearer?
It avoids initializing the same storage twice.

--- incremen.c.~1.45.~  2006-05-16 16:31:51.000000000 -0700
+++ incremen.c  2006-05-29 21:23:53.000000000 -0700
@@ -117,8 +117,10 @@ static struct directory *
 make_directory (const char *name)
 {
   size_t namelen = strlen (name);
-  size_t size = offsetof (struct directory, name) + namelen + 1;
+  size_t header_size = offsetof (struct directory, name);
+  size_t size = header_size + namelen + 1;
   struct directory *directory = xmalloc (size);
+  memset (directory, 0, header_size);
   strcpy (directory->name, name);
   if (ISSLASH (directory->name[namelen-1]))
     directory->name[namelen-1] = 0;