[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#24535: [PATCH] sed: fix incorrect match for title case

From: Norihiro Tanaka
Subject: bug#24535: [PATCH] sed: fix incorrect match for title case
Date: Sun, 25 Sep 2016 14:49:11 +0900

On Sat, 24 Sep 2016 20:43:01 -0700
Jim Meyering <address@hidden> wrote:

> Thank you for that patch.
> Quick feedback:
> Did you intend to use the new function, require_el_iso88597_locale_?
> Please replace this line from your new test (I prefer to avoid double
> quoting strings intended to contain backslashes, because each must be
> doubled, and that impairs readability/maintainability):
>   printf "/\\(\\)\\\\1$chr/Ip" >prog || fail=1
> with this:
>   printf '/\(\)\\1'"$chr"/Ip >prog || fail=1
> Is that a stray "-f -n" in the test script? This cannot work as intended:
>   $ sed -f -n -f prog in >out
>   sed: couldn't open file -n: No such file or directory

Thanks for quick feedback.  Sorry, I seem that I extracted the patch
from old repository.  I fixed it, and ru-run all tests and they are

Attachment: 0001-sed-fix-incorrect-match-for-title-case.patch
Description: Text document

reply via email to

[Prev in Thread] Current Thread [Next in Thread]