bug-recutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Recfix fails without warning on non-existent files


From: John Darrington
Subject: Re: Recfix fails without warning on non-existent files
Date: Tue, 2 Jun 2020 14:22:53 +0200
User-agent: Mutt/1.10.1 (2018-07-13)

Thanks.

I would have written this something like:

   if (!db)
     {
       int err = errno;
       fprintf (stderr, _("recfix: error: cannot read file %s: %s"), 
recfix_file, strerror (err));
       return EXIT_FAILURE;
     }

That way, the user gets a hint about *why* recfix cannot read the file.

J'


On Tue, Jun 02, 2020 at 02:14:43PM +0200, Jose E. Marchesi wrote:
     
         If I type "recfix /no/such/file" then recfix (correctly) returns 1,
         but  does not print anything on stdout/stderr
         
         I think it ought to give some kind of warning that the file does
         not exist.
         
     Fixed in git.
     Thanks!



reply via email to

[Prev in Thread] Current Thread [Next in Thread]