Fwd: build bash-5.2.21 on debian-hurd-x86_64

[Guy-Fleury Iteriteka]

-------- Original Message --------
From: gfleury <gfleury@disroot.org>
Sent: January 5, 2024 10:02:30 AM GMT+02:00
To: bug-hurd@gnu.org
Subject: build  bash-5.2.21  on debian-hurd-x86_64

Hello,

I copy bash-5.2.21 source to build it on debian hurd x86_64 and it failed with
---------
gcc -L./builtins -L./lib/readline -L./lib/readline -L./lib/glob -L./lib/tilde 
-L./lib/malloc -L./lib/sh  -L./lib/termcap  -g -O2   -o bash shell.o eval.o 
y.tab.o general.o make_cmd.o print_cmd.o  dispose_cmd.o execute_cmd.o 
variables.o copy_cmd.o error.o expr.o flags.o jobs.o subst.o hashcmd.o 
hashlib.o mailcheck.o trap.o input.o unwind_prot.o pathexp.o sig.o test.o 
version.o alias.o array.o arrayfunc.o assoc.o braces.o bracecomp.o bashhist.o 
bashline.o  list.o stringlib.o locale.o findcmd.o redir.o pcomplete.o 
pcomplib.o syntax.o xmalloc.o  -lbuiltins -lglob -lsh -lreadline -lhistory 
./lib/termcap/libtermcap.a -ltilde -lmalloc    -ldl
/usr/bin/ld: 
./lib/termcap/libtermcap.a(termcap.o):/home/gfleury/bash-5.2.21/build/lib/termcap/../../../lib/termcap/termcap.c:298:
 multiple definition of `PC'; 
./lib/readline/libreadline.a(terminal.o):/home/gfleury/bash-5.2.21/build/lib/readline/../../../lib/readline/terminal.c:109:
 first defined here
/usr/bin/ld: 
./lib/termcap/libtermcap.a(tparam.o):/home/gfleury/bash-5.2.21/build/lib/termcap/../../../lib/termcap/tparam.c:126:
 multiple definition of `BC'; 
./lib/readline/libreadline.a(terminal.o):/home/gfleury/bash-5.2.21/build/lib/readline/../../../lib/readline/terminal.c:109:
 first defined here
/usr/bin/ld: 
./lib/termcap/libtermcap.a(tparam.o):/home/gfleury/bash-5.2.21/build/lib/termcap/../../../lib/termcap/tparam.c:127:
 multiple definition of `UP'; 
./lib/readline/libreadline.a(terminal.o):/home/gfleury/bash-5.2.21/build/lib/readline/../../../lib/readline/terminal.c:109:
 first defined here
/usr/bin/ld: ./lib/sh/libsh.a(tmpfile.o): in function `sh_mktmpname':
/home/gfleury/bash-5.2.21/build/lib/sh/../../../lib/sh/tmpfile.c:160:(.text+0x17f):
 warning: the use of `mktemp' is dangerous, better use `mkstemp' or `mkdtemp'
collect2: error: ld returned 1 exit status
make: *** [Makefile:595: bash] Error 1
-------

with this small patch i managed to build it and seems to get rid of some weird 
character before prompt '?2004lroot@hurd:~#'

--- lib/readline/terminal.c     2024-01-05 09:36:25.394494448 +0200
+++ lib/readline/terminal.c     2024-01-05 09:36:57.022494473 +0200
@@ -102,7 +102,7 @@

 static int tcap_initialized;

-#if !defined (__linux__) && !defined (NCURSES_VERSION)
+#if !defined (__linux__) && !defined (__GNU__) && !defined (NCURSES_VERSION)
 #  if defined (__EMX__) || defined (NEED_EXTERN_PC)
 extern
 #  endif /* __EMX__ || NEED_EXTERN_PC */