[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-readline] heap-buffer-overflow in update_line
From: |
Chet Ramey |
Subject: |
Re: [Bug-readline] heap-buffer-overflow in update_line |
Date: |
Thu, 23 May 2019 08:38:11 -0400 |
User-agent: |
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 5/23/19 3:33 AM, Tom de Vries wrote:
> Using this additional bit:
> ...
> @@ -528,6 +533,8 @@ rl_redisplay ()
> init_line_structures (0);
> rl_on_new_line ();
> }
> + else if (line_size <= _rl_screenwidth)
> + init_line_structures (_rl_screenwidth + 1);
>
> /* Draw the line into the buffer. */
> cpos_buffer_position = -1;
> ...
> I managed to fix the assert also in this scenario, and managed to run
> the entire gdb testsuite without triggering the assert.
>
> Is that a good code change?
It looks like it will solve that problem, and perhaps more. Thanks for the
patch.
Chet
--
``The lyf so short, the craft so long to lerne.'' - Chaucer
``Ars longa, vita brevis'' - Hippocrates
Chet Ramey, UTech, CWRU address@hidden http://tiswww.cwru.edu/~chet/
- [Bug-readline] heap-buffer-overflow in update_line, Tom de Vries, 2019/05/08
- Re: [Bug-readline] heap-buffer-overflow in update_line, Chet Ramey, 2019/05/16
- Re: [Bug-readline] heap-buffer-overflow in update_line, Tom de Vries, 2019/05/17
- Re: [Bug-readline] heap-buffer-overflow in update_line, Chet Ramey, 2019/05/17
- Re: [Bug-readline] heap-buffer-overflow in update_line, Chet Ramey, 2019/05/20
- Re: [Bug-readline] heap-buffer-overflow in update_line, Tom de Vries, 2019/05/23
- Re: [Bug-readline] heap-buffer-overflow in update_line,
Chet Ramey <=
- Re: [Bug-readline] heap-buffer-overflow in update_line, Tom de Vries, 2019/05/23
- Re: [Bug-readline] heap-buffer-overflow in update_line, Chet Ramey, 2019/05/24