[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-readline] [PATCH] configure.ac, readline.pc.in: fix Requires.pr
From: |
Chet Ramey |
Subject: |
Re: [Bug-readline] [PATCH] configure.ac, readline.pc.in: fix Requires.private value |
Date: |
Wed, 2 May 2018 10:33:17 -0400 |
User-agent: |
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 5/2/18 10:04 AM, Thomas Petazzoni wrote:
> Hello Chet,
>
> On Mon, 23 Apr 2018 11:52:54 -0400, Chet Ramey wrote:
>>> The provided readline.pc.in hardcodes the fact that readline depends
>>> on the tinfo library. However, different termcap implementation are
>>> supported beyond tinfo. This commit improves the configure.ac script
>>> to define a TERMCAP_PKG_CONFIG_LIB variable, which is then used in
>>> readline.pc.in.
>>>
>>> This for example allows the generated readline.pc to properly contain
>>> "Requires.private: ncurses" when ncurses is used as the termcap
>>> implementation.
>>
>> Thanks for the report and patch.
>
> Thanks for the feedback. Does this means that my patch has been applied
> or will be applied ?
Yes, it's in the current readline devel git branch on savannah.gnu.org.
> If so, I'd like to provide another patch that makes sure the .pc file
> is installed by default, so that it can be used by other packages,
> through pkg-config. Would this make sense ?
Sure, send it along.
Chet
--
``The lyf so short, the craft so long to lerne.'' - Chaucer
``Ars longa, vita brevis'' - Hippocrates
Chet Ramey, UTech, CWRU address@hidden http://tiswww.cwru.edu/~chet/