Re: [Bug-readline] making shared link failures fatal

[Mike Frysinger]

On Fri, Mar 25, 2011 at 2:50 PM, Chet Ramey wrote:
> On 3/24/11 1:22 PM, Mike Frysinger wrote:
>> On Thu, Mar 24, 2011 at 11:14 AM, Chet Ramey wrote:
>>>> atm, any link failure in the shared library dir is ignored.  is this
>>>> really necessary considering there is a --disable-shared configure
>>>> flag ?
>>>>
>>>> here's a patch i wrote long ago:
>>>> http://sources.gentoo.org/sys-libs/readline/files/readline-5.2-no-ignore-shlib-errors.patch
>>>
>>> I'm reluctant to do this, because shared library creation and installation
>>> is enabled by default.  I don't want to kill a build because the install
>>> fails.  The --disable-shared option is something a user has to specify, and
>>> few people do that the first time out.
>>
>> but it ignores both build and install errors.  the former is certainly
>> more important to me than the latter.
>
> The question is whether or not a failure to build the shared version of
> readline should cause the build to fail, even if the static library is
> created successfully.

i cant see how ignoring the shared link is sane anymore.  what
reasonable OS doesnt use shared libraries anymore ?

how unreasonable is it really to have the 1 or 2 random people running
on old pos hardware to pass --disable-shared at configure time ?

or even better, why not just convert to libtool already ?  every other
major project out there has long ago switched to libtool.  that would
detect whether the target supports shared libraries at configure time
and disable it by default.
-mike